Skip to content

Moving BuildSignPodManager from the pod to the buildsign package #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Mar 2, 2025
Merged

Moving BuildSignPodManager from the pod to the buildsign package #1035

k8s-ci-robot merged 1 commit into from
Mar 2, 2025

Conversation

@yevgeny-shnaidman
Copy link
Contributor

@yevgeny-shnaidman yevgeny-shnaidman commented Feb 27, 2025 •
edited
Loading

BuildSignPodManager interface is used only by the build and sign packages.
Since we are moving into buildsign package, it make sense to move that
interface there, especially as it is a porting layer

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2025
@netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit dffe22a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/67c08bb77cfd7f000808f7cb
😎 Deploy Preview https://deploy-preview-1035--kubernetes-sigs-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.30%. Comparing base (fa23a9b) to head (dffe22a).
Report is 223 commits behind head on main.

Files with missing lines Patch % Lines
cmd/manager-hub/main.go 0.00% 1 Missing ⚠️
cmd/manager/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
- Coverage   79.09%   73.30%   -5.80%     
==========================================
  Files          51       73      +22     
  Lines        5109     6214    +1105     
==========================================
+ Hits         4041     4555     +514     
- Misses        882     1471     +589     
- Partials      186      188       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ybettan
Copy link
Contributor

ybettan commented Feb 27, 2025

I would rename the commit title to

Moving BuildSignPodManager from the `pod` to the `buildsign` package.

And also updating the commit message accordingly.

@ybettan
Copy link
Contributor

ybettan commented Feb 27, 2025

Do you plan to remove the Maker and Signer interfaces and add their methods to the BuildSignPodManager interface in a separate PR?

@yevgeny-shnaidman
Copy link
Contributor Author

yevgeny-shnaidman commented Feb 27, 2025

Do you plan to remove the Maker and Signer interfaces and add their methods to the BuildSignPodManager interface in a separate PR?

Yes

@yevgeny-shnaidman
Moving BuildSignPodManager from the pod to the buildsign package.
dffe22a 
BuildSignPodManager interface is used only by the build and sign packages.
Since we are moving into buildsign package, it make sense to move that
interface there, especially as it is a porting layer
@yevgeny-shnaidman yevgeny-shnaidman force-pushed the yevgeny/move-buildsignpod branch from 6f4867f to dffe22a Compare February 27, 2025 15:58
@yevgeny-shnaidman
Copy link
Contributor Author

yevgeny-shnaidman commented Feb 27, 2025

I would rename the commit title to

Moving BuildSignPodManager from the `pod` to the `buildsign` package.

And also updating the commit message accordingly.

Fixed

@yevgeny-shnaidman yevgeny-shnaidman changed the title Moving buildsignpod package under buildsign package Moving BuildSignPodManager from the pod to the buildsign package Feb 27, 2025
@ybettan
Copy link
Contributor

ybettan commented Mar 2, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit fa3731a into kubernetes-sigs:main Mar 2, 2025
22 checks passed
cdvultur pushed a commit to cdvultur/kernel-module-management that referenced this pull request Oct 22, 2025
@qbarrand
Move webhooks to a separate Deployment (kubernetes-sigs#1035)
d9c6aeb 
Adapt deployment files and tests.

Upstream-Commit: 5665c56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mresvanis mresvanis Awaiting requested review from mresvanis

@ybettan ybettan Awaiting requested review from ybettan

Assignees

@ybettan ybettan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yevgeny-shnaidman @k8s-ci-robot @codecov-commenter @ybettan